Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: site setting to disable usernames in share links. #18315

Merged
merged 2 commits into from
Sep 22, 2022
Merged

FEATURE: site setting to disable usernames in share links. #18315

merged 2 commits into from
Sep 22, 2022

Conversation

vinothkannans
Copy link
Member

@vinothkannans vinothkannans commented Sep 21, 2022 •
edited

Previously, it included the username if badges are enabled. It raised some privacy concerns in meta.discourse couple of times.

@CvX
Copy link
Contributor

CvX commented Sep 22, 2022

Test failures need to be addressed

@vinothkannans vinothkannans merged commit 998bd19 into main Sep 22, 2022
@vinothkannans vinothkannans deleted the share-link-username branch September 22, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegangeorge keegangeorge keegangeorge approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@vinothkannans @CvX @keegangeorge